chore: disable snaps feat from main temporarily #10278
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10278 +/- ##
==========================================
- Coverage 49.67% 49.67% -0.01%
==========================================
Files 1450 1450
Lines 34888 34891 +3
Branches 3950 3951 +1
==========================================
+ Hits 17330 17331 +1
- Misses 16456 16458 +2
Partials 1102 1102 ☔ View full report in Codecov by Sentry. |
FrederikBolding
approved these changes
Jul 10, 2024
tommasini
approved these changes
Jul 10, 2024
Jonathansoufer
added
the
No QA Needed
metamaskbot
added
release-7.28.0
|
Missing release label release-7.27.0 on PR. Adding release label release-7.27.0 on PR and removing other release labels(release-7.28.0), as PR was cherry-picked in branch 7.27.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR disable preinstalled-snaps from main build since no feature will be using it at this point. The first feature relying on preinstalled-snap (signing-snap) is notifications, which is not part of the current release.
Related issues
Fixes:
Manual testing steps
N/A
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist